Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Add rendering of template variables to environment variables #30

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Add rendering of template variables to environment variables #30

merged 5 commits into from
Dec 15, 2020

Conversation

soenkeliebau
Copy link
Member

fixes #29

@lfrancke
Copy link
Member

Would you mind merging main before I review?

@soenkeliebau
Copy link
Member Author

I've merged

lfrancke
lfrancke suggested changes Dec 14, 2020
View reviewed changes
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments but I'm mostly unsure what the "rust way" to do things would be here

matklad
matklad reviewed Dec 15, 2020
View reviewed changes
lfrancke
lfrancke previously approved these changes Dec 15, 2020
View reviewed changes
Copy link
Member

@lfrancke lfrancke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request but if you don't want to it's already good to go

@soenkeliebau
Copy link
Member Author

I've added the comment you asked for.

@soenkeliebau soenkeliebau merged commit f2dd280 into stackabletech:main Dec 15, 2020
@soenkeliebau soenkeliebau deleted the env_templates branch December 15, 2020 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@matklad matklad matklad left review comments

@lfrancke lfrancke lfrancke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent doesn't replace variables in environment variables
3 participants
@soenkeliebau @lfrancke @matklad