Skip to content
This repository was archived by the owner on Dec 21, 2021. It is now read-only.

Restrict permissions of private key file #235

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

siegfriedweber
Copy link
Member

@siegfriedweber siegfriedweber commented Jul 23, 2021

Fixes #215

Description

The access rights of the private key file are restricted to the owner when it is created. On existing installations this must be done manually.

The fix was actually done in krustlet:

This is not testable in the agent-integration-tests.

Review Checklist

  • Code contains useful comments
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)

@siegfriedweber siegfriedweber requested a review from a team July 23, 2021 09:49
@siegfriedweber siegfriedweber self-assigned this Jul 23, 2021
@siegfriedweber siegfriedweber force-pushed the restrict_file_permissions branch from ac8b672 to 0b47bac Compare July 23, 2021 11:32
The access rights of the private key file are restricted to the owner
when it is created. On existing installations this must be done
manually.
@siegfriedweber siegfriedweber force-pushed the restrict_file_permissions branch from 0b47bac to 6f0c287 Compare July 26, 2021 07:07
Copy link
Member

@soenkeliebau soenkeliebau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siegfriedweber siegfriedweber merged commit 3bf2e8c into main Jul 26, 2021
@siegfriedweber siegfriedweber deleted the restrict_file_permissions branch July 26, 2021 09:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent private key permissions are too permissive
2 participants