Test changes for custom database corruption error handler #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 13, 2015 13:29
…opened, and check state after (expected to be closed)
… that was never opened in custom DatabaseErrorHandler, near the beginning of the test suite
This was referenced Aug 28, 2015
|
Look good @brodybits - thanks! 👍 |
developernotes
added a commit
that referenced
this pull request
Aug 28, 2015
Test changes for custom database corruption error handler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes further testing of the default database corruption error handler, in case the database file is corrupted after opening successfully.
Ref: sqlcipher/android-database-sqlcipher#169 sqlcipher/android-database-sqlcipher#192
The new CustomCorruptionHandlerTest could probably use some serious refactoring. I will look into it if I get a chance, someday.