Fix build when using Android NDK >= r9 #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android NDK tools places all generated libraries under $PROJECT/libs directory. Since android-ndk-r9, at least on Ubuntu, NDK Tools places generated *.so under libs/, while we expect them under $(EXTERNAL_DIR)/libs and $(JNI_DIR)/libs The solution is to specify libraries directory using NDK_LIBS_OUT. NDK docs: android-ndk-r9b/docs/OVERVIEW.html III.6/ Specifying custom output directories Reports about this bug: https://groups.google.com/d/msg/sqlcipher/cbt5ZOVMgEk/kiiWi4e8fIoJ https://groups.google.com/d/msg/sqlcipher/WqDDsH4nUtE/EYUcSJ8G2L0J
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Android NDK tools places all generated libraries under
$PROJECT/libsdirectory.Since android-ndk-r9, at least on Ubuntu, NDK Tools places generated
*.sounderlibs/while we expect them under$(EXTERNAL_DIR)/libsand$(JNI_DIR)/libs.The solution is to specify libraries directory using
NDK_LIBS_OUT.NDK docs:
android-ndk-r9b/docs/OVERVIEW.html III.6/ Specifying custom output directories
Reports about this bug:
https://groups.google.com/d/msg/sqlcipher/cbt5ZOVMgEk/kiiWi4e8fIoJ
https://groups.google.com/d/msg/sqlcipher/WqDDsH4nUtE/EYUcSJ8G2L0J