internal/mysql: Port tests to endtoend package #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cmoog Care to take a look? |
kyleconroy
commented
Jan 31, 2020
Comment on lines
+10
to
+11
| john FirstNameType = "john" | ||
| albert FirstNameType = "albert" |
There was a problem hiding this comment.
We're going to have to fix the naming here. These should be
const (
FirstNameJohn FirstNameType = "john"
FirstNameAlbert FirstNameType = "albert"
)There was a problem hiding this comment.
It's fine for now, will address it in another PR.
There was a problem hiding this comment.
Good find. I must have written some unfortunately narrow tests that didn't catch that before.
|
Looks good to me 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of my work on #302, I wanted to avoid having to update the MySQL tests to use the new configuration format. When tests are written using the end-to-end framework, none of the internal structures leak into the tests.