Skip to content

fix(compiler): Add validation for GROUP BY clause column references #1285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 18, 2021

Conversation

timstudd
Copy link
Contributor

No description provided.

@timstudd
Copy link
Contributor Author

Fixes #1284

@timstudd timstudd force-pushed the fix/validate-group-by-col-ref branch from e861ce6 to 71a8291 Compare November 14, 2021 13:50
Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add a test for MySQL?

@timstudd timstudd requested a review from kyleconroy November 17, 2021 20:37
@kyleconroy kyleconroy merged commit 710cc21 into sqlc-dev:main Nov 18, 2021
@timstudd timstudd deleted the fix/validate-group-by-col-ref branch November 24, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants