Skip to content

Consider Aligning MvcRequestMatcher's matching methods #9300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

Consider Aligning MvcRequestMatcher's matching methods #9300

merged 1 commit into from
Jan 11, 2021

Conversation

evgeniycheban
Copy link
Contributor

Closes gh-9284

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 19, 2020
jzheaux
jzheaux requested changes Jan 5, 2021
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban! I've left some feedback inline.

@jzheaux jzheaux self-assigned this Jan 5, 2021
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 5, 2021
@evgeniycheban evgeniycheban requested a review from jzheaux January 9, 2021 06:41
@evgeniycheban evgeniycheban force-pushed the gh-9284 branch 2 times, most recently from 90a1d40 to d710266 Compare January 9, 2021 07:10
@evgeniycheban
Copy link
Contributor Author

@jzheaux Something is wrong with the PR build.

Could not GET 'https://repo.spring.io/libs-snapshot/com/fasterxml/jackson/datatype/jackson-datatype-jsr310/2.12.1/jackson-datatype-jsr310-2.12.1.pom'. Received status code 401 from server: Unauthorized

@jzheaux jzheaux merged commit 8449df9 into spring-projects:master Jan 11, 2021
@jzheaux
Copy link
Contributor

jzheaux commented Jan 11, 2021

Thanks, @evgeniycheban! This is now merged into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: web An issue in web modules (web, webmvc) type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider Aligning MvcRequestMatcher's matching methods
3 participants
@evgeniycheban @jzheaux @spring-projects-issues