Add DefaultRelyingPartyRegistrationResolver #8899
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniycheban
suggested changes
Aug 4, 2020
...ngframework/security/saml2/provider/service/web/DefaultRelyingPartyRegistrationResolver.java
Outdated
Show resolved
Hide resolved
...ngframework/security/saml2/provider/service/web/DefaultRelyingPartyRegistrationResolver.java
Outdated
Show resolved
Hide resolved
...ingframework/security/config/annotation/web/configurers/saml2/Saml2LoginConfigurerTests.java
Outdated
Show resolved
Hide resolved
...mework/security/saml2/provider/service/web/DefaultRelyingPartyRegistrationResolverTests.java
Outdated
Show resolved
Hide resolved
| private Saml2AuthenticationRequestContextResolver getContextResolver(B http) { | ||
| Saml2AuthenticationRequestContextResolver resolver = getBeanOrNull(http, Saml2AuthenticationRequestContextResolver.class); | ||
| if (resolver == null) { | ||
| return new DefaultSaml2AuthenticationRequestContextResolver( |
There was a problem hiding this comment.
I think it would be better to have a single return statement.
new DefaultSaml2AuthenticationRequestContextResolver can be moved into getDefaultContextResolver method.
There was a problem hiding this comment.
I'm of a different opinion on this one. I think returning early is more readable.
However, since that's probably in the eye of the beholder, what I'd propose for now is aligning with how other similar methods in the class, like getResolver. We can consider changing both methods at another time.
|
Thanks for the feedback, @evgeniycheban, it was very helpful. I incorporated it and committed the changes in 015281f to |
jzheaux
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.