Update SimpleSaml2AuthenticatedPrincipal class name #8861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
Jul 21, 2020
...ework/security/saml2/provider/service/authentication/DefaultSaml2AuthenticatedPrincipal.java
Outdated
Show resolved
Hide resolved
...ework/security/saml2/provider/service/authentication/DefaultSaml2AuthenticatedPrincipal.java
Show resolved
Hide resolved
jzheaux
requested changes
Jul 21, 2020
There was a problem hiding this comment.
Thanks for the quick response, @JoakimLofgren! I've left just one more comment inline.
...ework/security/saml2/provider/service/authentication/DefaultSaml2AuthenticatedPrincipal.java
Outdated
Show resolved
Hide resolved
Rename it to DefaultSaml2AuthenticatedPrincipal to be more in line with the respective class in the OAuth2 module. Also make the class public to be able to whitelist the SAML2 auth classes in Jackson object mappers for deserialization in e.g. Spring Session MongoDB. Closes spring-projectsgh-8852
jzheaux
approved these changes
Jul 23, 2020
|
Thanks, @JoakimLofgren! This is now merged into |
jzheaux
added
in: saml2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename it to DefaultSaml2AuthenticatedPrincipal to be more in line with
the respective class in the OAuth2 module.
Also make the class public to be able to whitelist the SAML2 auth classes
in Jackson object mappers for deserialization in e.g. Spring Session MongoDB.
Closes gh-8852