Skip to content

DefaultOAuth2AuthorizationRequestResolver Should Not Consume Request Body #8651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DefaultOAuth2AuthorizationRequestResolver Should Not Consume Request Body #8651

wants to merge 1 commit into from

Conversation

eamelink
Copy link
Contributor

@eamelink eamelink commented Jun 4, 2020

Per the servlet spec, getParameter(name) consumes the request body for POST requests. This commit prevents DefaultOAuth2AuthorizationRequestResolver from consuming the request body for non-Authorization requests.

Fixes #8650

@eamelink
Don't consume request body. Fixes spring-projectsgh-8650
69685a8 
Per the servlet spec, getParameter(name) consumes the request body for POST requests. This commit prevents DefaultOAuth2AuthorizationRequestResolver from consuming the request body for non-Authorization requests.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jun 4, 2020
@jzheaux jzheaux self-assigned this Jun 5, 2020
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 5, 2020
@jzheaux
Copy link
Contributor

jzheaux commented Jun 5, 2020

Thanks, @eamelink! This is now merged into master via cd3fd67

@jzheaux jzheaux closed this Jun 5, 2020
@jzheaux jzheaux changed the title Don't consume request body. Fixes gh-8650 DefaultOAuth2AuthorizationRequestResolver Should Not Consume Request Body Jun 5, 2020
@jzheaux jzheaux added this to the 5.4.0-M2 milestone Jun 5, 2020
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
5.4.0-M2
Development

Successfully merging this pull request may close these issues.

DefaultOAuth2AuthorizationRequestResolver erroneously consumes POST request body
3 participants
@eamelink @jzheaux @spring-projects-issues