Add OAuth2Authorization success/failure handlers #7986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgrandja
added
type: enhancement
philsttr
reviewed
Feb 19, 2020
| * @return a {@link Mono} that completes empty after the authorization failure handler completes | ||
| */ | ||
| private Mono<Void> handleHttpStatus(ClientRequest request, int httpStatusCode, @Nullable Exception exception) { | ||
| return Mono.justOrEmpty(this.httpStatusToOAuth2ErrorCodeMap.get(httpStatusCode)) |
There was a problem hiding this comment.
This applies to both the servlet impl and the reactive impl.... But this could theoretically check for (and parse) a WWW-Authenticate header returned from the resource server. It likely contains the details necessary to create an OAuth2Error object. This would be preferred (and then perhaps fallback to the httpStatusCode -> oauth2ErrorCode mapping if details could not be extracted from WWW-Authenticate).
For example:
HTTP/1.1 403 Forbidden
WWW-Authenticate: Bearer error="insufficient_scope", error_description="The request requires higher privileges than provided by the access token.", error_uri="https://tools.ietf.org/html/rfc6750#section-3.1"
There was a problem hiding this comment.
Good idea! Let me see what I can do here.
There was a problem hiding this comment.
@philsttr I added the improvement as suggested. This is now in master.
|
Merged via 69156b7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-7840