Set secure on cookie when logging out #7764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to mark cookie secure flag with request.isSecure() to ensure cookie identity is same
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Dec 27, 2019
| assertThat(response.getCookies()).hasSize(1); | ||
| assertThat(response.getCookies()[0].getSecure()).isTrue(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add a test checking that when the request is not secure, then the cookie is not secure.
eleftherias
added
in: web
|
@eleftherias I added the test you requested, thanks. |
eleftherias
changed the title
|
Thanks for the PR @okohub! This is now merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is better to mark cookie secure flag with request.isSecure() to ensure cookie identity is same