Removes the need for a CSRF token with mock JWT #7276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Changes the JwtRequestPostProcessor to remove the check for a CSRF token in the request. Fixes spring-projectsgh-7170
rwinch
requested changes
Aug 19, 2019
There was a problem hiding this comment.
Thanks for the PR @henriquels25! Please see inline for comments
| * {@link RequestMatcher} | ||
| * @param requestMatcher the {@link RequestMatcher} to set | ||
| */ | ||
| public static void setCsrfRequestMatcher(HttpServletRequest request, |
There was a problem hiding this comment.
We cannot do this because it dirties the context since additional requests without a jwt token would also ignore CSRF protection. The CSRF request should be disabled for just this request.
It might be better to:
- Update CsrfFilter.shouldNotFilter to return true if a specific request attribute is set
- Modify the code to set the attribute when jwt is being invoked
rwinch
added
in: web
|
Closing in favor of #7368 which addresses the concerns listed in #7276 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: gh-7170
Changes the JwtRequestPostProcessor to remove the check for a CSRF token in the request.
If there is a more elegant way to change the RequestMatcher of the request CsrfFilter, please let me know.