DSL nested builder for HTTP security #7046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eleftherias
force-pushed
the
gh-5557-dsl-nested-builder
branch
2 times, most recently
from
2f9990e to
eeabb5c
Compare
eleftherias
changed the title
eleftherias
force-pushed
the
gh-5557-dsl-nested-builder
branch
from
eeabb5c to
8931800
Compare
eleftherias
force-pushed
the
gh-5557-dsl-nested-builder
branch
from
3eccb45 to
ce98f79
Compare
eleftherias
force-pushed
the
gh-5557-dsl-nested-builder
branch
from
ce98f79 to
4b2539d
Compare
eleftherias
commented
Jul 10, 2019
| @@ -1,5 +1,5 @@ | |||
| /* | |||
There was a problem hiding this comment.
featurePolicy() has not been updated to allow lambda configuration.
This is because there is no reasonable default for the policyDirectives argument.
Instead, it can be the last configuration for headers().
http
.headers(headers ->
headers
.defaultsDisabled()
.referrerPolicy(referrerPolicy ->
referrerPolicy.policy(ReferrerPolicy.SAME_ORIGIN)
)
.featurePolicy("")
);
eleftherias
commented
Jul 10, 2019
| */ | ||
| public OpenIDLoginConfigurer<H> attributeExchange(Customizer<AttributeExchangeConfigurer> attributeExchangeCustomizer) | ||
| throws Exception { | ||
| AttributeExchangeConfigurer attributeExchangeConfigurer = new AttributeExchangeConfigurer(".*"); |
There was a problem hiding this comment.
The default attribute exchange identifier pattern is ".*" to match everything. It can be updated using the new identifierPattern() method.
eleftherias
commented
Jul 10, 2019
| * @see AttributeExchangeConfigurer#attribute(String) | ||
| */ | ||
| private AttributeConfigurer() { | ||
| this.name = "default-attribute"; |
There was a problem hiding this comment.
The default attribute name is "default-attribute". This is primarily to avoid a NullPointerException, users should override the name in the name() setter.
rwinch
added
in: config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: gh-5557