Skip to content

MockMvc Support Allows Specifying Jwt #6923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2019
Merged

MockMvc Support Allows Specifying Jwt #6923

merged 1 commit into from
Jun 12, 2019

Conversation

sandmannn
Copy link
Contributor

@sandmannn sandmannn commented May 30, 2019 •
edited
Loading

This is the first PR to address extension of testing API as described in #6896

@pivotal-issuemaster
Copy link

@sandmannn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label May 30, 2019
@sandmannn sandmannn mentioned this pull request May 30, 2019
Closed
@pivotal-issuemaster
Copy link

@sandmannn Thank you for signing the Contributor License Agreement!

@jzheaux
Copy link
Contributor

jzheaux commented Jun 1, 2019

@sandmannn Thanks for the PR! Would you please add a unit test that proves that the method works?

Also, will you please squash your commits so that you just have one commit in the PR?

@sandmannn
Copy link
Contributor Author

@jzheaux thanks for the review, I squashed commits and added a single unit test. Please suggest in case some additional testing scenarios are desired.

@jzheaux
Copy link
Contributor

jzheaux commented Jun 10, 2019

Just one more thing, @sandmannn. Would you please add the ticket number into your commit message like so.

@jzheaux jzheaux self-assigned this Jun 10, 2019
@jzheaux jzheaux added in: test An issue in spring-security-test status: duplicate A duplicate of another issue type: improvement and removed status: waiting-for-triage An issue we've not yet triaged labels Jun 10, 2019
@sandmannn
Extended testing api for JWT
212b21a 
Added new implementation of jwt() method that
makes it possible to directly provide a previously
prepared JWT token to the MockMvc request builder.

Issue: spring-projectsgh-6896
@sandmannn
Copy link
Contributor Author

Just one more thing, @sandmannn. Would you please add the ticket number into your commit message like so.

Done, please review corrected commit message

@jzheaux
Copy link
Contributor

jzheaux commented Jun 10, 2019

Could you please change it to say "Fixes: gh-6896".

The reason for that is that we use "Issue: gh-6896" to indicate that a given commit contributes to an issue but does not necessarily fix it. Since your commit completely fixes the issue, it should say "Fixes: gh-6896".

@sandmannn
Copy link
Contributor Author

Could you please change it to say "Fixes: gh-6896".

The reason for that is that we use "Issue: gh-6896" to indicate that a given commit contributes to an issue but does not necessarily fix it. Since your commit completely fixes the issue, it should say "Fixes: gh-6896".

actually I am not sure if my commit completely fixes the issue, as the fix for reactive client is still pending to be added in separate PR. Should I still use Fixes?

@jzheaux jzheaux merged commit 9323d8e into spring-projects:master Jun 12, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Jun 12, 2019

Good point, @sandmannn. This is now merged into master.

Would you like to provide a PR for the reactive equivalent?

@sandmannn
Copy link
Contributor Author

Thanks for merging. Yes, I already started looking into code. Will create a PR soon.

@rwinch rwinch changed the title Extended testing api for tests MockMvc Support Allows Specifying Jwt Jun 13, 2019
@rwinch rwinch added this to the 5.2.0.M3 milestone Jun 13, 2019
@rwinch rwinch removed the status: duplicate A duplicate of another issue label Jun 13, 2019
@sandmannn sandmannn deleted the test-jwt branch November 24, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jzheaux jzheaux

Labels
in: test An issue in spring-security-test
Projects
None yet
Milestone
5.2.0.M3
Development

Successfully merging this pull request may close these issues.
5 participants
@sandmannn @pivotal-issuemaster @jzheaux @rwinch @spring-projects-issues