-
Notifications
You must be signed in to change notification settings - Fork 6.1k
rewrite docs - gh 2567 master merge march 2019 #6593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fhanik
wants to merge
70
commits into
spring-projects:master
from
fhanik:gh-2567-master-merge-march-2019
Closed
rewrite docs - gh 2567 master merge march 2019 #6593
fhanik
wants to merge
70
commits into
spring-projects:master
from
fhanik:gh-2567-master-merge-march-2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO continue namespace migration
I edited for spelling, grammar, punctuation, usage, consistency, and corporate voice. I also more formally formatted the code samples.
Rob Winch made some changes in the reference manual, and I caught up with him by editing for spelling, punctuation, grammar, usage, and corporate voice (all the usual stuff). I also added some links in places where Rob had included FIXME tags to add links and the other content had the necessary anchors.
Servlet capitalization consistency
We have performed some polish on your URLs. We do not follow redirects to avoid expanding intentionally shorter URLs (i.e. URL shortened URLs) # Fixed URLs ## Fixed But Review Recommended These URLs were fixed, but the https status was not OK. However, the https status was the same as the http request, so we migrated them. Your review is recommended. | HTTP URL | Result URL | HTTPS Result | HTTP Result | Count | | --- | --- | --- | --- | --- | | http://repository.springsource.com/maven/bundles/external | https://repository.springsource.com/maven/bundles/external | HttpResponse(httpStatus = 404 NOT_FOUND) | HttpResponse(httpStatus = 404 NOT_FOUND) | 1 | | http://repository.springsource.com/maven/bundles/release | https://repository.springsource.com/maven/bundles/release | HttpResponse(httpStatus = 404 NOT_FOUND) | HttpResponse(httpStatus = 404 NOT_FOUND) | 1 | ## Fixed Success These URLs were fixed successfully. | HTTP URL | Result URL | HTTPS Result | HTTP Result | Count | | --- | --- | --- | --- | --- | | http://www.apache.org/licenses/LICENSE-2.0 | https://www.apache.org/licenses/LICENSE-2.0 | HttpResponse(httpStatus = 200 OK) | null | 10 |
Test merge from rewrite into master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review of merge attempt from rewrite docs branch to master as of March 05, 2019.
#2567