Add DelegatingSecurityContextTaskScheduler #6257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwinch
requested changes
Dec 7, 2018
There was a problem hiding this comment.
Thanks for the PR! I have provided feedback inline.
Can you also:
- create a specific
DelegatingSecurityContextTaskSchedulerTest? - squash the commits
- ensure the remaining message aligns with the Spring Security conventions?
...ain/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java
Outdated
Show resolved
Hide resolved
.../java/org/springframework/security/scheduling/AbstractSecurityContextTaskSchedulerTests.java
Outdated
Show resolved
Hide resolved
...springframework/security/scheduling/ExplicitSecurityContextSchedulingTaskSchedulerTests.java
Outdated
Show resolved
Hide resolved
rwinch
requested changes
Dec 12, 2018
There was a problem hiding this comment.
Thanks for the changes!
- It appears that there are some checkstyle failures. Can you please look into fixing those:
[ant:checkstyle] [ERROR] /home/travis/build/spring-projects/spring-security/core/src/main/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java:38: Line has leading space characters; indentation should be performed with tabs only. [RegexpSinglelineJava]
[ant:checkstyle] [ERROR] /home/travis/build/spring-projects/spring-security/core/src/main/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java:54:52: ',' is not followed by whitespace. [WhitespaceAfter]
You can run checkstyle using ./gradlew checkstyleMain checkstyleTest
-
Can you please add tests?
-
Can you also please squash your commits and please update the commit message to align with the Spring Security conventions?
|
I will make those changes. |
...springframework/security/scheduling/ExplicitSecurityContextSchedulingTaskSchedulerTests.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java
Outdated
Show resolved
Hide resolved
rwinch
requested changes
Dec 14, 2018
...java/org/springframework/security/scheduling/DelegatingSecurityContextTaskSchedulerTest.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java
Outdated
Show resolved
Hide resolved
...ain/java/org/springframework/security/scheduling/DelegatingSecurityContextTaskScheduler.java
Show resolved
Hide resolved
rwinch
changed the title
richardvaldiviesomacias
force-pushed
the
gh-6043-TaskScheduler-variant
branch
4 times, most recently
from
af83f72 to
fae0d4e
Compare
rwinch
added
in: core
rwinch
requested changes
Dec 17, 2018
There was a problem hiding this comment.
Thanks for the updates. I just noticed (sorry about that) that the documentation hasn't been updated yet. Can you please update it? Once that is done we will be ready to merge.
rwinch
added
the
status: waiting-for-feedback
abstraction for Runnable that can be used for async and scheduled tasks. The primary contract for task scheduling is TaskScheduler and there's no such wrapper available at the moment. The new DelegatingSecurityContextTaskScheduler class implements TaskScheduler interface. Fixes spring-projectsgh-6043
richardvaldiviesomacias
force-pushed
the
gh-6043-TaskScheduler-variant
branch
from
fae0d4e to
a95b6ff
Compare
|
Done. Thanks for all your help 😁 |
rwinch
removed
the
status: waiting-for-feedback
|
@richardvaldiviesomacias Thanks for the fast turnaround! This is now merged into master. Thank you for taking the time to make Spring better. We hope to see you again soon (submitting a PR, issue, etc)! If you are looking for issues to help with the label Help Wanted is a sign that the issue is relatively small. Just comment on the issue to claim it before starting work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Security provides a TaskScheduler variant or the documentation routes users to expose a TaskScheduler bean rather than exposing a ScheduledExecutorService bean.
New file: DelegatingSecurityContextTaskScheduler which is a DelegatingSecurityContextAsyncTaskExecutor thant implements TaskScheduler.
ExplicitSecurityContextSchedulingTaskSchedulerTests and AbstractSecurityContextTaskSchedulerTests for testing.