Make MethodSecurityEvaluationContext Delegates to MethodBasedEvaluationContext #6249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbuos
changed the title
…onContext Spring Security's MethodSecurityEvaluationContext should delegate to Spring Framework's MethodBasedEvaluationContext Fixes: spring-projectsgh-6224
spring-projects-issues
added
the
status: waiting-for-triage
eleftherias
suggested changes
Oct 15, 2019
There was a problem hiding this comment.
Thanks for the PR @dbuos! I have left one comment inline. Additionally, can you please rebase on the latest master code, as there are currently some conflicts
Comment on lines
-51
to
-53
| public MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi) { | ||
| this(user, mi, new DefaultSecurityParameterNameDiscoverer()); | ||
| } |
There was a problem hiding this comment.
Is it necessary to remove this constructor? Although it is only intended for testing, removing it would not be backward compatible
There was a problem hiding this comment.
Hi @eleftherias I'll proceed to check the comment and rebase, thanks for your comment.
There was a problem hiding this comment.
@dbuos Have you had the chance to review the requested changes?
eleftherias
added
status: feedback-provided
eleftherias
added
status: waiting-for-feedback
eleftherias
added
in: core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Security's MethodSecurityEvaluationContext should delegate to Spring Framework's
MethodBasedEvaluationContext
Fixes: gh-6224