-
Notifications
You must be signed in to change notification settings - Fork 6.1k
OAuth2AccessTokenResponseBodyExtractor supports Object values #6096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@raphaelDL Thank you so much for the PR! The code is exactly what I had imagined. I have a few minor suggestions that help ensure project consistency.
@Test
// gh-6087
public void oauth2AccessTokenResponseWhenMultipleAttributeTypesThenCreated() throws Exception { You can make these changes locally, amend the commit, and force push to your branch and this PR will be updated. As always, if you have any questions, feedback, or need any help, please don't hesitate to reach out. Thanks again for your help! |
Working on it :) |
93fd7dd
to
2bf5d70
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR and the fast turnaround on the changes. I had one more comment inline and then we are ready to merge. Thanks again for contributing!
|
||
|
||
@Test | ||
// Fixes: gh-6087 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the convention is that the commit message says "Fixes: ", the comment should just be gh-6087. Can you please change this and then I think we are ready to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
This commit ensures the token response is parsed correctly if the values are not a String. Fixes: spring-projectsgh-6087
Thanks for the PR @raphaelDL! This is now merged into master. I also backported your commit into 5.1.x via #6100 |
From #6087
@rwinch help please, I took this one but I wonder if this is the right approach for this. What do you think?