InMemoryUserDetailsManager.updatePassword case-insenstive #6039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dperezcabrera Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@dperezcabrera Thank you for signing the Contributor License Agreement! |
dperezcabrera
changed the title
gburboz
reviewed
Nov 4, 2018
core/src/main/java/org/springframework/security/provisioning/InMemoryUserDetailsManager.java
Show resolved
Hide resolved
gburboz
reviewed
Nov 4, 2018
core/src/main/java/org/springframework/security/provisioning/InMemoryUserDetailsManager.java
Show resolved
Hide resolved
gburboz
reviewed
Nov 6, 2018
core/src/main/java/org/springframework/security/provisioning/InMemoryUserDetailsManager.java
Show resolved
Hide resolved
|
Thanks for the PR @dperezcabrera! Could you please add a test for this? |
rwinch
added
status: waiting-for-feedback
|
I would like to add this change to milestone 5.1.2 if possible. Should I change the origin and destination branch to 5.1.x? |
rwinch
requested changes
Nov 9, 2018
core/src/test/java/org/springframework/security/core/userdetails/PasswordEncodedUser.java
Outdated
Show resolved
Hide resolved
|
@dperezcabrera Thanks for the fast turnaround. I have an additional comment on the code. Can you please address that? If you can fix this issue I mentioned above #6039 (comment), I will be glad to backport the fix. |
rwinch
requested changes
Nov 9, 2018
core/src/test/java/org/springframework/security/core/userdetails/PasswordEncodedUser.java
Outdated
Show resolved
Hide resolved
...src/test/java/org/springframework/security/provisioning/InMemoryUserDetailsManagerTests.java
Show resolved
Hide resolved
dperezcabrera
force-pushed
the
master
branch
2 times, most recently
from
c5a9b5f to
56d81fc
Compare
rwinch
changed the title
rwinch
approved these changes
Nov 9, 2018
rwinch
removed
the
status: waiting-for-feedback
rwinch
pushed a commit
that referenced
this pull request
Nov 9, 2018
Previously updatePassword was case sensitive which was inconsistent with the rest of the class. This commit updates updatePassword to be case insensitive. Fixes: gh-6039
|
Thanks for the PR! This is now merged into master and backported to 5.1.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When username is not in lowercase It throws a null pointer exception.