Skip to content

Fixing X509 Principal Extractor regex examples #5770 #5988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 17, 2018
Merged

Fixing X509 Principal Extractor regex examples #5770 #5988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
739c194
Update x509.adoc
sunflower-seed Oct 17, 2018
34eaa13
Update SubjectDnX509PrincipalExtractor.java
sunflower-seed Oct 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/manual/src/docs/asciidoc/_includes/servlet/additional-topics/x509.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ The `subject-principal-regex` should contain a single group.
For example the default expression "CN=(.*?)," matches the common name field.
So if the subject name in the certificate is "CN=Jimi Hendrix, OU=...", this will give a user name of "Jimi Hendrix".
The matches are case insensitive.
So "emailAddress=(.?)," will match "[email protected],CN=..." giving a user name "[email protected]".
So "emailAddress=(+.*?+)," will match "[email protected],CN=..." giving a user name "[email protected]".
If the client presents a certificate and a valid username is successfully extracted, then there should be a valid `Authentication` object in the security context.
If no certificate is found, or no corresponding user could be found then the security context will remain empty.
This means that you can easily use X.509 authentication with other options such as a form-based login.
Expand Down
2 changes: 1 addition & 1 deletion ...ngframework/security/web/authentication/preauth/x509/SubjectDnX509PrincipalExtractor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
* expression "CN=(.*?)(?:,|$)" matches the common name field. So
* "CN=Jimi Hendrix, OU=..." will give a user name of "Jimi Hendrix".
* <p>
* The matches are case insensitive. So "emailAddress=(.?)," will match
* The matches are case insensitive. So "emailAddress=(.*?)," will match
* "[email protected], CN=..." giving a user name "[email protected]"
*
* @author Luke Taylor
Expand Down