Add new factory method for creating DelegatingPasswordEncoder #4670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kazuki43zoo This solution poses a problem because the user does not have a reference to existing id's so they would have to read the code to enable it. I'm not even sure if this is a good approach overall. If users want more flexibility, they can create an instances using We could discuss some alternative builder possibilities, but at the moment I'm not convinced we should add them since using |
rwinch
added
status: declined
|
@rwinch Thanks for your comment. I agree with your opinion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See gh-4666
I will propose to add new factory method that can specify the id of an encoder for encoding password.
What do you think?