Skip to content

Support new event for indicates logout success #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kazuki43zoo
Copy link
Contributor

  • I have signed the CLA

Fixes gh-3307

Original PR is gh-222.

@pivotal-issuemaster
Copy link

pivotal-issuemaster commented Jun 9, 2016

@kazuki43zoo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@rwinch rwinch modified the milestone: 4.2.0 M1 Aug 15, 2016
@pivotal-issuemaster
Copy link

@kazuki43zoo Thank you for signing the Contributor License Agreement!

@rwinch
Copy link
Member

rwinch commented Aug 30, 2016

@kazuki43zoo Thanks for the PR!

I think it might make more sense to place this in a LogoutHandler so that the logic can be reused wherever a logout occurs. Specifically, I think it makes sense in the SecurityContextLogoutHandler

@rwinch rwinch self-assigned this Aug 30, 2016
@rwinch rwinch added the status: waiting-for-feedback We need additional information before we can continue label Aug 30, 2016
@kazuki43zoo
Copy link
Contributor Author

@rwinch Thanks for comment!! I will remake this and submit a other PR at later.

@rwinch rwinch removed the status: waiting-for-feedback We need additional information before we can continue label Aug 30, 2016
@rwinch rwinch removed this from the 4.2.0 M1 milestone Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEC-3105: Support LogoutSuccessEvent
3 participants