Fix unauthenitcated() and AnonymousAuthenticationToken #3818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| @Test | ||
| public void unauthenitcatedNullAuthenitcation() throws Exception { |
rwinch
force-pushed
the
gh-3409-unauthenticated
branch
from
3319fd9 to
d694468
Compare
|
|
||
| // @formatter:off | ||
| @Autowired | ||
| public void configureGlobal(AuthenticationManagerBuilder auth) throws Exception { |
There was a problem hiding this comment.
The authManager configuration is redundant?
There was a problem hiding this comment.
I meant redundant in the sense that the authManager configuration is not needed to pass the test
There was a problem hiding this comment.
Thanks for the clarification. I pushed an update
Previously if unauthenticated() experienced an AnonymousAuthenticationToken it would not match. This commit ensures that if the user is anonymous (not just null) unauthenticated() works. Fixes spring-projectsgh-3409
rwinch
force-pushed
the
gh-3409-unauthenticated
branch
from
d694468 to
b2b53f7
Compare
|
Thanks @rwinch! It is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if unauthenticated() experienced an AnonymousAuthenticationToken
it would not match.
This commit ensures that if the user is anonymous (not just null)
unauthenticated() works.
Fixes gh-3409