Skip to content

Make X509CertificateThumbprintValidator to be public and non-final class #17178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@
* "https://datatracker.ietf.org/doc/html/rfc8705#section-3.1">3.1. JWT Certificate
* Thumbprint Confirmation Method</a>
*/
final class X509CertificateThumbprintValidator implements OAuth2TokenValidator<Jwt> {
public class X509CertificateThumbprintValidator implements OAuth2TokenValidator<Jwt> {

static final Supplier<X509Certificate> DEFAULT_X509_CERTIFICATE_SUPPLIER = new DefaultX509CertificateSupplier();
public static final Supplier<X509Certificate> DEFAULT_X509_CERTIFICATE_SUPPLIER = new DefaultX509CertificateSupplier();

private final Log logger = LogFactory.getLog(getClass());

private final Supplier<X509Certificate> x509CertificateSupplier;

X509CertificateThumbprintValidator(Supplier<X509Certificate> x509CertificateSupplier) {
public X509CertificateThumbprintValidator(Supplier<X509Certificate> x509CertificateSupplier) {
Assert.notNull(x509CertificateSupplier, "x509CertificateSupplier cannot be null");
this.x509CertificateSupplier = x509CertificateSupplier;
}
Expand Down Expand Up @@ -109,7 +109,7 @@ public OAuth2TokenValidatorResult validate(Jwt jwt) {
return OAuth2TokenValidatorResult.success();
}

static String computeSHA256Thumbprint(X509Certificate x509Certificate) throws Exception {
public static String computeSHA256Thumbprint(X509Certificate x509Certificate) throws Exception {
MessageDigest md = MessageDigest.getInstance("SHA-256");
byte[] digest = md.digest(x509Certificate.getEncoded());
return Base64.getUrlEncoder().withoutPadding().encodeToString(digest);
Expand Down