-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add SingleResultAuthorizationManager #16612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
...ain/java/org/springframework/security/authorization/SingleResultAuthorizationManager.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
/* | ||
* Copyright 2002-2025 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.security.authorization; | ||
|
||
import java.util.function.Supplier; | ||
|
||
import org.springframework.security.core.Authentication; | ||
import org.springframework.util.Assert; | ||
|
||
/** | ||
* An {@link AuthorizationManager} which creates permit-all and deny-all | ||
* {@link AuthorizationManager} instances. | ||
* | ||
* @author Max Batischev | ||
* @since 6.5 | ||
*/ | ||
public final class SingleResultAuthorizationManager<C> implements AuthorizationManager<C> { | ||
|
||
private static final SingleResultAuthorizationManager<?> DENY_MANAGER = new SingleResultAuthorizationManager<>( | ||
new AuthorizationDecision(false)); | ||
|
||
private static final SingleResultAuthorizationManager<?> PERMIT_MANAGER = new SingleResultAuthorizationManager<>( | ||
new AuthorizationDecision(true)); | ||
|
||
private final AuthorizationResult result; | ||
|
||
public SingleResultAuthorizationManager(AuthorizationResult result) { | ||
Assert.notNull(result, "result cannot be null"); | ||
this.result = result; | ||
} | ||
|
||
@Override | ||
public AuthorizationDecision check(Supplier<Authentication> authentication, C object) { | ||
if (!(this.result instanceof AuthorizationDecision)) { | ||
throw new IllegalArgumentException("result should be AuthorizationDecision"); | ||
} | ||
return (AuthorizationDecision) this.result; | ||
} | ||
|
||
@Override | ||
public AuthorizationResult authorize(Supplier<Authentication> authentication, C object) { | ||
return this.result; | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
public static <C> SingleResultAuthorizationManager<C> denyAll() { | ||
return (SingleResultAuthorizationManager<C>) DENY_MANAGER; | ||
} | ||
|
||
@SuppressWarnings("unchecked") | ||
public static <C> SingleResultAuthorizationManager<C> permitAll() { | ||
return (SingleResultAuthorizationManager<C>) PERMIT_MANAGER; | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 77 additions & 0 deletions
77
...ava/org/springframework/security/authorization/SingleResultAuthorizationManagerTests.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,77 @@ | ||
/* | ||
* Copyright 2002-2025 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.security.authorization; | ||
|
||
import org.junit.jupiter.api.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; | ||
|
||
/** | ||
* Tests for {@link SingleResultAuthorizationManager}. | ||
* | ||
* @author Max Batischev | ||
*/ | ||
public class SingleResultAuthorizationManagerTests { | ||
|
||
private SingleResultAuthorizationManager<?> manager; | ||
|
||
@Test | ||
void authorizeWhenManagerWithGrantedAuthorizationResultIsCreatedThenAuthorizes() { | ||
this.manager = new SingleResultAuthorizationManager<>(new AuthorizationDecision(true)); | ||
|
||
AuthorizationResult result = this.manager.authorize(null, null); | ||
|
||
assertThat(result.isGranted()).isTrue(); | ||
} | ||
|
||
@Test | ||
void checkWhenManagerWithGrantedDecisionIsCreatedThenAuthorizes() { | ||
this.manager = new SingleResultAuthorizationManager<>(new AuthorizationDecision(true)); | ||
|
||
AuthorizationResult result = this.manager.check(null, null); | ||
|
||
assertThat(result.isGranted()).isTrue(); | ||
} | ||
|
||
@Test | ||
void checkWhenManagerWithGrantedCustomAuthorizationResultIsCreatedThenFails() { | ||
this.manager = new SingleResultAuthorizationManager<>((AuthorizationResult) () -> true); | ||
|
||
assertThatIllegalArgumentException().isThrownBy(() -> this.manager.check(null, null)); | ||
} | ||
|
||
@Test | ||
void authorizeWhenPermitManagerUsesThenAuthorize() { | ||
AuthorizationResult result = SingleResultAuthorizationManager.permitAll().authorize(null, null); | ||
|
||
assertThat(result.isGranted()).isTrue(); | ||
} | ||
|
||
@Test | ||
void authorizeWhenDenyManagerUsesThenDeny() { | ||
AuthorizationResult result = SingleResultAuthorizationManager.denyAll().authorize(null, null); | ||
|
||
assertThat(result.isGranted()).isFalse(); | ||
} | ||
|
||
@Test | ||
void constructWhenNullResultIsPresentThenFails() { | ||
assertThatIllegalArgumentException().isThrownBy(() -> new SingleResultAuthorizationManager<>(null)); | ||
} | ||
|
||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.