Fix getBeansWithName in global authentication configurers #15781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
Kehrlann
force-pushed
the
fix/initialize-manager-configurer
branch
from
d622592 to
76eef54
Compare
Kehrlann
force-pushed
the
fix/initialize-manager-configurer
branch
from
76eef54 to
d68b1ed
Compare
rwinch
approved these changes
Sep 11, 2024
rwinch
added
in: config
|
Thanks for the Pull Request! This is now merged into main 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a small bug with
getBeansWithNamein bothInitializeAuthenticationProviderBeanManagerConfigurerandInitializeUserDetailsBeanManagerConfigurer, where we returned a list containing n copies of the same bean.This did not have any functional impact as we only ever use the list when there is only one element in it.
Please merge forward to main.