Augment role hierarchy in RoleHierarchyImpl Builder
#15307
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes spring-projectsgh-15264 Signed-off-by: Niels Basjes <[email protected]>
Closes spring-projectsgh-15264 Signed-off-by: Niels Basjes <[email protected]>
Signed-off-by: Niels Basjes <[email protected]>
Signed-off-by: Niels Basjes <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
marcusdacoregio
added
in: core
|
Fixed via #15717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change (as I have the code here) requires #15272 to be merged (and this should be rebased before merging).
Assume this role mapping in text send to the
RoleHierarchyImpl:The expectation is that this code fragment of using the
RoleHierarchyImplBuilder would yield the same effect:The current behavior of the Builder is that this results in the role "X" ONLY being assigned the role "B" (the last one assigned).
With this change the the role "X" will be assigned BOTH the roles "A" and "B" making it the same as the text format again.
FYI: @marcusdacoregio