Skip to content

gh-14525 Extend `org.springframework.security.web.authentication.logo… #14526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aspan
Copy link
Contributor

@aspan aspan commented Feb 1, 2024

…ut.LogoutFilterso that the relying party initiated logout filter is ordered before the existingorg.springframework.security.web.authentication.logout.LogoutFilter`

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 1, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Feb 5, 2024

Thanks for the fix, @aspan. Are you able to rebase this off of 5.8.x so that I can forward port it to the other branches more easily?

@jzheaux jzheaux self-assigned this Feb 5, 2024
@jzheaux jzheaux added type: bug A general bug in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 5, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Feb 5, 2024

And, could you please do two more things to simplify future maintenance:

  • Run ./gradlew format to align your changes with the project formatting standards
  • Change the commit to be formatted similar to this:
Saml2 LogoutFilter Is Placed Before Common LogoutFilter

Closes gh-14525

The main thrust is the title should be short and there should be the phrase "Closes gh-14525" in the description.

@aspan
Copy link
Contributor Author

aspan commented Feb 5, 2024

Reformatted code and changed the commit message. Also made a separate pull request for the 5.8.x branch.

@jzheaux
Copy link
Contributor

jzheaux commented Feb 5, 2024

Awesome, thanks @aspan! I'll close this in favor of #14549.

@jzheaux jzheaux closed this Feb 5, 2024
@jzheaux jzheaux added the status: duplicate A duplicate of another issue label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants