Store HttpServletResponse used by LazyCsrfTokenRepository in an appropriately prefixed request attribute #13056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
added
in: web
|
Thanks, @chschu, I've been thinking about this a bit more. To remain backward compatible, I think that we'd need to keep using both the new and the old attribute names. This is because the request attributes we set are part of the public API when they are used across classes. Given that extra complexity and that the illegal name isn't removed after all, I think that #13194 is a better use of time. We can remove the attribute altogether in #13196 in the next major release. I'm going to close this PR and would encourage you to contribute to #13196 once Spring Security 7 comes around. |
jzheaux
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes gh-6452 by storing the
HttpServletResponsein a non-reserved request attribute.