Skip to content

Updating the NimbusReactiveJwtDecoder.JwkSetUriReactiveJwtDecoderBuil… #12965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

meverden
Copy link

@meverden meverden commented Apr 4, 2023

…der processor to execute the ConfigurableJWTProcessor customizations before holding a reference to the JWSKeySelector.

Creating a PR to address #12960

@pivotal-cla
Copy link

@meverden Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 4, 2023
@pivotal-cla
Copy link

@meverden Thank you for signing the Contributor License Agreement!

@jzheaux jzheaux self-assigned this Apr 10, 2023
@jzheaux jzheaux added type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 10, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Apr 10, 2023

Thanks, @meverden! The PR looks great. Will you please do the following house-keeping items in your PR?

  1. Please rebase off of 5.7.x so that all active branches get the fix
  2. Please format your commit to something more like this:
Delay JWSVerificationKeySelector Construction

<< any other commentary needed >>

Closes gh-12960
  1. Please update the copyright date on any files that you edit (the test file should now say 2023 as the end date)
  2. Once ready, please squash any commits into a single one

@jzheaux jzheaux added this to the 5.7.x milestone Apr 10, 2023
@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label Apr 10, 2023
Updating the NimbusReactiveJwtDecoder.JwkSetUriReactiveJwtDecoderBuilder processor to execute the ConfigurableJWTProcessor customizations before holding a reference to the JWSKeySelector.

Closes spring-projectsgh-12960
@meverden meverden changed the base branch from main to 5.7.x April 11, 2023 16:11
@meverden
Copy link
Author

@jzheaux, this branch is now based off 5.7.x, copyright dates have been updated in all locations, commit message has been reformatted and squashed.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Apr 11, 2023
@jzheaux jzheaux modified the milestones: 5.7.x, 5.7.8 Apr 12, 2023
@jzheaux jzheaux added status: duplicate A duplicate of another issue and removed status: feedback-provided Feedback has been provided labels Apr 12, 2023
@jzheaux jzheaux merged commit c4e9fb8 into spring-projects:5.7.x Apr 12, 2023
@jzheaux
Copy link
Contributor

jzheaux commented Apr 12, 2023

Thanks, @meverden, for the PR! This is now merged into 5.7.x, 5.8.x, 6.0.x, and main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants