Skip to content

SecuredAuthorizationManager should allow customizing underlying authorization manager #12488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2023
Merged

SecuredAuthorizationManager should allow customizing underlying authorization manager #12488

merged 1 commit into from
Jan 11, 2023

Conversation

evgeniycheban
Copy link
Contributor

@evgeniycheban evgeniycheban commented Jan 6, 2023 •
edited
Loading

SecuredAuthorizationManager should allow customizing underlying authorization manager

Closes gh-12233

@evgeniycheban evgeniycheban changed the title SecuredAuthorizationManager should allow customizing underlying autho… SecuredAuthorizationManager should allow customizing underlying authorization manager Jan 6, 2023
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 6, 2023
jzheaux
jzheaux requested changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban! I've left some feedback inline.

...main/java/org/springframework/security/authorization/method/SecuredAuthorizationManager.java Outdated
* authority strings to use
* @since 6.1
*/
public void setDelegate(AuthorizationManager<Collection<String>> delegate) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer that this method name be more descriptive. What about setAuthoritiesAuthorizationManager?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jzheaux jzheaux self-assigned this Jan 6, 2023
@jzheaux jzheaux added status: duplicate A duplicate of another issue in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 6, 2023
@jzheaux jzheaux added this to the 6.1.0-M1 milestone Jan 6, 2023
@evgeniycheban evgeniycheban requested a review from jzheaux January 6, 2023 19:23
@jzheaux jzheaux merged commit 782b792 into spring-projects:main Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Milestone
6.1.0-M1
Development

Successfully merging this pull request may close these issues.

SecuredAuthorizationManager should allow customizing underlying authorization manager
3 participants
@evgeniycheban @jzheaux @spring-projects-issues