Allow authorization request resolver to be changed for the OAuth2 client configuration #12438
Conversation
…ient configuration
|
@spoptchev Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
spring-projects-issues
added
the
status: waiting-for-triage
|
@spoptchev Thank you for signing the Contributor License Agreement! |
There was a problem hiding this comment.
Thanks for the PR @spoptchev !
Can you also please add a test similar to OAuth2LoginTests.oauth2LoginWhenCustomObjectsThenUsed(). We should test if a custom authorizationRequestResolver is set then it is used. I think all you need to modify is OAuth2ClientSpecTests.oauth2ClientWhenCustomObjectsThenUsed().
| * @param authorizationRequestResolver the resolver used for resolving | ||
| * {@link OAuth2AuthorizationRequest}'s | ||
| * @return the {@link OAuth2ClientSpec} for further configuration | ||
| */ |
jgrandja
added
type: enhancement
|
@jgrandja I added the test. Let me know if something is missing. |
|
Thanks for the updates @spoptchev. This is now merged. FYI, I added a polish commit with some minor updates in order to get this merged as I am off until the new year. Enjoy the holidays! |
|
@jgrandja thank you for the integration. Happy holidays 🎄 |
Fixes gh-12430.
See issue for details.