SecuredAuthorizationManager should cache annotation's value #12335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
evgeniycheban
force-pushed
the
gh-12232
branch
from
b5505cd to
8f75c6f
Compare
marcusdacoregio
requested review from
jzheaux
and removed request for
jzheaux
jzheaux
requested changes
Jan 4, 2023
There was a problem hiding this comment.
Thanks, @evgeniycheban! This looks great. I left a piece of feedback inline.
Also, now that we are in 2023, will you please update the copyright year for these files?
| @@ -74,14 +74,14 @@ void checkWhenUserHasNotAnyAuthorityThenDeniedDecision() { | |||
| } | |||
|
|
|||
| @Test | |||
| void hasRoleWhenRoleHierarchySetThenGreaterRoleTakesPrecedence() { | |||
| void checkWhenRoleHierarchySetThenGreaterRoleTakesPrecedence() { | |||
There was a problem hiding this comment.
Will you please put this in a separate commit with a comment that describes why the change was made? By doing that, each commit will stay focused on one atomic change.
jzheaux
added
status: duplicate
- Update copyright header - Use Set.of instead of HashSet in AuthorityAuthorizationManager - Align roleHierarchy test name with other tests in AuthoritiesAuthorizationManagerTests
evgeniycheban
force-pushed
the
gh-12232
branch
from
8f75c6f to
153e02b
Compare
jzheaux
approved these changes
Jan 5, 2023
|
Thanks, @evgeniycheban! This is now merged into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes gh-12232