Skip to content

Refresh remote JWK when unknown KID error occurs #11638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

sjohnr
Copy link
Contributor

@sjohnr sjohnr commented Jul 27, 2022

Closes gh-11621

@sjohnr sjohnr added status: duplicate A duplicate of another issue type: bug A general bug in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) labels Jul 27, 2022
@sjohnr sjohnr requested a review from jzheaux July 27, 2022 17:47
@sjohnr sjohnr self-assigned this Jul 27, 2022
@sjohnr sjohnr force-pushed the gh-11621-unknown-kid branch 2 times, most recently from a626c1e to 89bb00c Compare July 27, 2022 19:01
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, @sjohnr! I've left some feedback inline.

@sjohnr sjohnr force-pushed the gh-11621-unknown-kid branch 2 times, most recently from a0c2454 to d1f9063 Compare August 11, 2022 18:37
@sjohnr sjohnr requested a review from jzheaux August 18, 2022 16:10
@sjohnr sjohnr force-pushed the gh-11621-unknown-kid branch from d1f9063 to e38b6e7 Compare August 18, 2022 21:18
@sjohnr sjohnr merged commit 9c02e83 into spring-projects:main Aug 18, 2022
@sjohnr sjohnr deleted the gh-11621-unknown-kid branch August 18, 2022 21:43
@sjohnr sjohnr added this to the 5.8.0-M3 milestone Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteJwkSet is not refreshed when encountering an unknown KID
3 participants