Skip to content

Publish CsrfTokenRepository as a shared configurer bean #9595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Apr 10, 2021 · 2 comments
Closed

Publish CsrfTokenRepository as a shared configurer bean #9595

jzheaux opened this issue Apr 10, 2021 · 2 comments
Assignees
@jzheaux
Labels
in: config An issue in spring-security-config status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Apr 10, 2021

Related to #8731, configurers can benefit from knowing the CsrfTokenRepository that has been configured.

For example, this is helpful when Saml2LogoutConfigurer configures the CsrfLogoutHandler.
@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement labels Apr 10, 2021
@jzheaux jzheaux added this to the 5.5.0-RC1 milestone Apr 10, 2021
@jzheaux jzheaux self-assigned this Apr 10, 2021
@jzheaux
Copy link
Contributor Author

jzheaux commented Apr 12, 2021

The original impetus for this ticket is #8731 and since it has been reopened for additional research, we'll reopen this one as well, just in case changes there require changes here.

@jzheaux jzheaux reopened this Apr 12, 2021
@jzheaux jzheaux modified the milestones: 5.5.0-RC1, 5.6.0-M1 Apr 12, 2021
jzheaux added a commit to jzheaux/spring-security that referenced this issue Apr 15, 2021
@jzheaux
Publish CsrfTokenRepository as shared object
0513827 
Closes spring-projectsgh-9595
@eleftherias eleftherias modified the milestones: 5.6.0-M1, 5.6.0-M2 Jul 19, 2021
@rwinch rwinch modified the milestones: 5.6.0-M2, 5.6.0-M3 Aug 16, 2021
akohli96 pushed a commit to akohli96/spring-security that referenced this issue Aug 25, 2021
@jzheaux
Publish CsrfTokenRepository as shared object
079c184 
Closes spring-projectsgh-9595
@sjohnr sjohnr modified the milestones: 5.6.0-M3, 5.6.0-RC1 Sep 20, 2021
@rwinch rwinch modified the milestones: 5.6.0-RC1, 5.6.0 Oct 19, 2021
@rwinch rwinch removed this from the 5.6.0 milestone Nov 12, 2021
@rwinch rwinch added this to the 5.7.0-M1 milestone Nov 12, 2021
@sjohnr sjohnr modified the milestones: 5.7.0-M1, 5.7.0-M2 Jan 14, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.0-M2, 5.7.0-M3 Feb 21, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 5.7.0-M3, 5.7.0-RC1 Mar 21, 2022
@rwinch rwinch modified the milestones: 5.7.0-RC1, 5.8.x Apr 18, 2022
@rwinch rwinch removed this from the 5.8.x milestone Jun 9, 2022
@jzheaux jzheaux added the status: declined A suggestion or change that we don't feel we should currently apply label Jun 21, 2022
@jzheaux
Copy link
Contributor Author

jzheaux commented Jun 21, 2022

The original reason for adding this ticket is no longer valid, given that the logout filters are placed before CsrfFilter.

@jzheaux jzheaux closed this as completed Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config status: declined A suggestion or change that we don't feel we should currently apply type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rwinch @jzheaux @sjohnr @eleftherias @marcusdacoregio