Skip to content

Match requests based on servlet dispatcher type #9205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eleftherias opened this issue Nov 16, 2020 · 1 comment · Fixed by #9278
Closed

Match requests based on servlet dispatcher type #9205

eleftherias opened this issue Nov 16, 2020 · 1 comment · Fixed by #9278
Assignees
@eleftherias @nmck257
Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Milestone
5.5.0-M2

Comments

@eleftherias
Copy link
Contributor

Add a matcher to match requests and apply security rules based on the servlet Dispatcher type (FORWARD,INCLUDE,REQUEST,ASYNC,ERROR).

Context

This will allow users to define what happens in the case of an ERROR dispatch.
This may help in cases such as gh-9181.
@eleftherias eleftherias added in: config An issue in spring-security-config type: enhancement A general enhancement labels Nov 16, 2020
@eleftherias eleftherias mentioned this issue Nov 16, 2020
Closed
@jzheaux jzheaux added the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Nov 25, 2020
@nmck257 nmck257 mentioned this issue Dec 11, 2020
Merged
@nmck257
Copy link
Contributor

nmck257 commented Dec 11, 2020

Created PR #9278 - let me know if I missed any functionality?

nmck257 added a commit to nmck257/spring-security that referenced this issue Dec 11, 2020
@nmck257
Introduced DispatcherType request matcher
0838d4d 
Created a DispatcherTypeRequestMatcher and corresponding methods
for configuring an HttpSecurity object. This enables filtering of
security rules based on the dispatcher type of the incoming servlet
request.

Closes spring-projectsgh-9205
eleftherias pushed a commit that referenced this issue Dec 14, 2020
@nmck257 @eleftherias
Introduced DispatcherType request matcher
6be25df 
Created a DispatcherTypeRequestMatcher and corresponding methods
for configuring an HttpSecurity object. This enables filtering of
security rules based on the dispatcher type of the incoming servlet
request.

Closes gh-9205
@eleftherias eleftherias added this to the 5.5.0-M2 milestone Dec 14, 2020
@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eleftherias eleftherias

@nmck257 nmck257

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
5.5.0-M2
Development

Successfully merging a pull request may close this issue.

Introduced DispatcherType request matcher nmck257/spring-security
3 participants
@jzheaux @eleftherias @nmck257