Skip to content

AuthNRequest#Destination contains the SP entity ID, not the IDP SSO URI #7494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fhanik opened this issue Sep 29, 2019 · 0 comments · Fixed by #7496
Closed

AuthNRequest#Destination contains the SP entity ID, not the IDP SSO URI #7494

fhanik opened this issue Sep 29, 2019 · 0 comments · Fixed by #7496
Assignees
@fhanik
Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Milestone
5.2.0

Comments

@fhanik
Copy link
Contributor

fhanik commented Sep 29, 2019

Currently: (Incorrect Destination)

<saml2p:AuthnRequest 
    Destination="http://localhost:8080/login/saml2/sso/simplesamlphp"
    ForceAuthn="false" ID="ARQ28ad7a9-931d-41e6-bb94-785b3279c11f" IsPassive="false"
    IssueInstant="2019-09-29T22:26:17.265Z"
    ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Version="2.0"
    xmlns:saml2p="urn:oasis:names:tc:SAML:2.0:protocol">

Should be: (Correct Destination)

<saml2p:AuthnRequest 
    Destination="https://simplesaml-for-spring-saml.cfapps.io/saml2/idp/SSOService.php"
    ForceAuthn="false" ID="ARQ28ad7a9-931d-41e6-bb94-785b3279c11f" IsPassive="false"
    IssueInstant="2019-09-29T22:26:17.265Z"
    ProtocolBinding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Version="2.0"
    xmlns:saml2p="urn:oasis:names:tc:SAML:2.0:protocol">
@fhanik fhanik added type: bug A general bug in: saml2 An issue in SAML2 modules labels Sep 29, 2019
@fhanik fhanik added this to the 5.2.0 milestone Sep 29, 2019
@fhanik fhanik self-assigned this Sep 29, 2019
@fhanik fhanik mentioned this issue Sep 30, 2019
Merged
fhanik added a commit to fhanik/spring-security that referenced this issue Sep 30, 2019
@fhanik
Correctly set "Destination" in AuthNRequest message
825192a 
Fixes spring-projectsgh-7494
spring-projects#7494
fhanik added a commit that referenced this issue Sep 30, 2019
@fhanik
Correctly set "Destination" in AuthNRequest message
9731386 
Fixes gh-7494
#7494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhanik fhanik

Labels
in: saml2 An issue in SAML2 modules type: bug A general bug
Projects
None yet
Milestone
5.2.0
Development

Successfully merging a pull request may close this issue.

Correctly populate the AuthNRequest attributes fhanik/spring-security
1 participant
@fhanik