-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add generic getClaim() method in ClaimAccessor #6947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @jgrandja, if needed I would be available to work on this issue |
@ThomasVitale That would be great! It should be pretty straight forward - similar to what we already have in |
Hi @jgrandja, I created a PR for the issue, what do you think? |
Hi, we just upgraded to Spring Boot from 2.1.1 to 2.2.0. Now we have a failing test for our custom jwtAuthenticationConverter. It seems the implementation of method Jwt.getClaimAsStringList() has changed. We had a case test where the authorization server sends a space separated list of authorities. In that case getClaimAsStringList() returned null and we did the parsing ourselves. Now it returns a list with the string value of the claim as its only entry. This makes it harder to distinguish between an actual list and a space separated string value. Was this intentional? |
@codemasterover9000 It's best to log a new issue instead of commenting on a closed issue. If you're still having problems, please log a new issue with as much detail as possible. |
We should add a convenience (default) method in
ClaimAccessor
, as follows:Related to comment
The text was updated successfully, but these errors were encountered: