Skip to content

Remove Servlet 3.0 Support in CacheControlHeadersWriter #6265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Dec 7, 2018 · 1 comment · Fixed by #6290
Closed

Remove Servlet 3.0 Support in CacheControlHeadersWriter #6265

jzheaux opened this issue Dec 7, 2018 · 1 comment · Fixed by #6290
Labels
in: web An issue in web modules (web, webmvc) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Milestone
5.2.0.M1

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Dec 7, 2018 •
edited
Loading

Related to #6220

CacheControlHeadersWriter checks first to see if HttpServletRequest#getHeader is available.

Since Spring Framework 5.x has a baseline of Servlet Spec 3.1, this check is no longer necessary as well as any tests.

The task here is to remove the check, remove the tests, and change the class to simply call the getHeader method directly in the hasHeader method.
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) type: enhancement A general enhancement labels Dec 7, 2018
@jzheaux jzheaux added this to the 5.2.0.M1 milestone Dec 7, 2018
@jzheaux jzheaux mentioned this issue Dec 7, 2018
Closed
7 tasks
@jzheaux jzheaux added the status: first-timers-only An issue that can only be worked on by brand new contributors label Dec 14, 2018
@ghost ghost mentioned this issue Dec 16, 2018
Merged
@ghost
Copy link

ghost commented Dec 16, 2018

Hello, I submitted a PR for this. I think I followed the contributor rules correctly!

jzheaux pushed a commit that referenced this issue Dec 18, 2018
@jzheaux
Remove servlet getHeader check and test
a919b4e 
Fixes: gh-6265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
in: web An issue in web modules (web, webmvc) status: first-timers-only An issue that can only be worked on by brand new contributors type: enhancement A general enhancement
Projects
None yet
Milestone
5.2.0.M1
Development

Successfully merging a pull request may close this issue.

Remove check for method HttpServletRequest#getHeader and related test
1 participant
@jzheaux