Skip to content

OIDC Provider Configuration for ConfigurationRegistrations #5647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzheaux opened this issue Aug 7, 2018 · 1 comment
Closed

OIDC Provider Configuration for ConfigurationRegistrations #5647

jzheaux opened this issue Aug 7, 2018 · 1 comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 7, 2018

JwtDecoders#fromOidcIssuerLocation produces a JwtDecoder based off of the OIDC Provider Configuration endpoint [1].

OidcConfigurationProvider uses this same endpoint to produce a ClientRegistration.Builder.

OidcConfigurationProvider#fromIssuer would be better named ClientRegistrations#fromOidcIssuerLocation to align with the approach that JwtDecoders takes.

Note that doing this will break the Boot team, so we will need to coordinate with them to get this done.

[1] - https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderConfig

@jzheaux jzheaux added this to the 5.1.0.RC1 milestone Aug 7, 2018
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) OIDC labels Aug 7, 2018
@jzheaux
Copy link
Contributor Author

jzheaux commented Aug 13, 2018

Related - #5584

jzheaux added a commit that referenced this issue Aug 20, 2018
Class is now final

Issue: gh-5647
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose)
Projects
None yet
Development

No branches or pull requests

2 participants