Skip to content

Ensure Serializable Components Have Serialization Sample #17038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue May 5, 2025 · 0 comments
Closed

Ensure Serializable Components Have Serialization Sample #17038

jzheaux opened this issue May 5, 2025 · 0 comments
Assignees
@jzheaux
Labels
in: core An issue in spring-security-core type: bug A general bug
Milestone
6.4.6

Comments

@jzheaux
Copy link
Contributor

jzheaux commented May 5, 2025

When any serializable component is added to Spring Security, a serialization sample must be generated. To ensure this, we should both add a test in SpringSecurityCoreVersionSerializableTests to find any Spring Security serialization class under test and fail if a .serialized file does not exist for the current version.
@jzheaux jzheaux added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels May 5, 2025
jzheaux added a commit that referenced this issue May 5, 2025
@jzheaux
Polish Serialization Tests
65d53be 
- Error when public, non-ignored, serializable file is missing a sample
- Provide mechanism for creating an InstancioApi from scratch

Issue gh-17038
jzheaux added a commit that referenced this issue May 5, 2025
@jzheaux
Add Missing Serializable Samples
39fdcea 
Issue gh-17038
jzheaux added a commit that referenced this issue May 5, 2025
@jzheaux
Ignore Serialization in Test Components
c3c2bcd 
Since we don't need to ensure the serializability of test components
across versions, we can ignore missing version UIDs when those
test components aren't about testing Java serialization.

Issue gh-17038
@jzheaux jzheaux closed this as completed in d04f707 May 5, 2025
@jzheaux jzheaux added in: core An issue in spring-security-core and removed status: waiting-for-triage An issue we've not yet triaged labels May 6, 2025
@jzheaux jzheaux self-assigned this May 6, 2025
@jzheaux jzheaux added this to the 6.4.6 milestone May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: bug A general bug
Projects
None yet
Milestone
6.4.6
Development

No branches or pull requests
1 participant
@jzheaux