Skip to content

Kotlin DSL should contain formLogin.usernameParameter and formLogin.passwordParameter #14474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ty-v1 opened this issue Jan 19, 2024 · 2 comments · Fixed by #14488
Closed

Kotlin DSL should contain formLogin.usernameParameter and formLogin.passwordParameter #14474

ty-v1 opened this issue Jan 19, 2024 · 2 comments · Fixed by #14488
Assignees
@marcusdacoregio @ty-v1
Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@ty-v1
Copy link
Contributor

ty-v1 commented Jan 19, 2024

Expected Behavior

The FormLoginDsl should contain usernameParameter and passwordParameter properties.

formLogin {
  usernameParameter = "account"
  passwordParameter = "pw"
}

Current Behavior

The FormLoginDsl does not contain these properties.

Context

FormLoginDsl

I cannot rename the HTTP parameters used for authentication in the Kotlin DSL.
@ty-v1 ty-v1 added status: waiting-for-triage An issue we've not yet triaged type: enhancement A general enhancement labels Jan 19, 2024
@marcusdacoregio
Copy link
Contributor

Hi, @ty-v1. Thanks for the report.

Would you be interested in submitting a PR that adds the support?

@marcusdacoregio marcusdacoregio added in: config An issue in spring-security-config status: ideal-for-contribution An issue that we actively are looking for someone to help us with and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 19, 2024
@ty-v1
Copy link
Contributor Author

ty-v1 commented Jan 20, 2024

Hi, @ty-v1. Thanks for the report.

Would you be interested in submitting a PR that adds the support?

Yes, I will submit a PR by next Friday at the latest.

ty-v1 added a commit to ty-v1/spring-security that referenced this issue Jan 24, 2024
@ty-v1
Add usernameParameter and passwordParameter to FormLoginDsl
3289684 
Closes spring-projectsgh-14474
@ty-v1 ty-v1 mentioned this issue Jan 24, 2024
Merged
@marcusdacoregio marcusdacoregio added the status: duplicate A duplicate of another issue label Jan 24, 2024
marcusdacoregio pushed a commit that referenced this issue Jan 24, 2024
@ty-v1 @marcusdacoregio
Add usernameParameter and passwordParameter to FormLoginDsl
bdc0bd6 
Closes gh-14474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcusdacoregio marcusdacoregio

@ty-v1 ty-v1

Labels
in: config An issue in spring-security-config status: duplicate A duplicate of another issue status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add usernameParameter and passwordParameter to FormLoginDsl ty-v1/spring-security
2 participants
@marcusdacoregio @ty-v1