Skip to content

Provide default implementations in UserDetails #14275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jzheaux opened this issue Dec 11, 2023 · 0 comments · Fixed by #14276
Closed

Provide default implementations in UserDetails #14275

jzheaux opened this issue Dec 11, 2023 · 0 comments · Fixed by #14276
Assignees
@jzheaux
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Dec 11, 2023

The methods isAccountNonExpired, isAccountNonLocked, isCredentialsNonExpired, and isEnabled are used less often.

It would be nice if they were already implemented, returning true for each one.

Note that this would align the interface with how UserBuilder treats these properties.
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement status: ideal-for-contribution An issue that we actively are looking for someone to help us with labels Dec 11, 2023
@ahmd-nabil ahmd-nabil mentioned this issue Dec 11, 2023
Merged
ahmd-nabil added a commit to ahmd-nabil/spring-security that referenced this issue Dec 11, 2023
@ahmd-nabil
Add default implementation in UserDetails
7604248 
Closes spring-projectsgh-14275

Signed-off-by: ahmd-nabil <[email protected]>
jzheaux pushed a commit that referenced this issue Dec 11, 2023
@ahmd-nabil @jzheaux
Add default implementation in UserDetails
dfef781 
Closes gh-14275

Signed-off-by: ahmd-nabil <[email protected]>
@jzheaux jzheaux removed the status: ideal-for-contribution An issue that we actively are looking for someone to help us with label Jun 20, 2024
@jzheaux jzheaux self-assigned this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add default implementations in UserDetails ahmd-nabil/spring-security
1 participant
@jzheaux