Skip to content

Copies of RelyingPartyRegistration should preserve custom fields #12841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #12840
jzheaux opened this issue Mar 7, 2023 · 0 comments
Closed
Tracked by #12840

Copies of RelyingPartyRegistration should preserve custom fields #12841

jzheaux opened this issue Mar 7, 2023 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Mar 7, 2023

When using RelyingPartyRegistration#withRelyingPartyRegistration as a copy constructor, custom data in subclasses cannot be preserved.

Instead of a static copy constructor, we should add a mutate() method that creates a builder based on an existing instances implementation. Then, subclasses of RelyingPartyRegistration can override the implementation to preserve custom data.

This will also ensure custom data like #12685 is preserved even when placeholder resolution is involved.

@jzheaux jzheaux added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Mar 7, 2023
@jzheaux jzheaux added this to the 6.1.0-M2 milestone Mar 7, 2023
@jzheaux jzheaux self-assigned this Mar 7, 2023
jzheaux added a commit to jzheaux/spring-security that referenced this issue Mar 17, 2023
jzheaux added a commit to jzheaux/spring-security that referenced this issue Mar 17, 2023
jzheaux added a commit that referenced this issue Mar 18, 2023
jzheaux added a commit to 1livv/spring-security that referenced this issue Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant