Skip to content

Add saml2Metadata to the DSL #11828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #12840
marcusdacoregio opened this issue Sep 16, 2022 · 0 comments
Closed
Tracked by #12840

Add saml2Metadata to the DSL #11828

marcusdacoregio opened this issue Sep 16, 2022 · 0 comments
Assignees
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Milestone

Comments

@marcusdacoregio
Copy link
Contributor

In order to publish the metadata endpoint, we should do:

DefaultRelyingPartyRegistrationResolver relyingPartyRegistrationResolver =
        new DefaultRelyingPartyRegistrationResolver(this.relyingPartyRegistrationRepository);
Saml2MetadataFilter filter = new Saml2MetadataFilter(
        relyingPartyRegistrationResolver,
        new OpenSamlMetadataResolver());

http
    // ...
    .saml2Login(withDefaults())
    .addFilterBefore(filter, Saml2WebSsoAuthenticationFilter.class);

It would be nice if we have a new method in the DSL that achieve the same behavior just by doing:

http
    // ...
   .saml2Login(withDefaults())
   .saml2Metadata(withDefaults());
@marcusdacoregio marcusdacoregio added type: enhancement A general enhancement in: saml2 An issue in SAML2 modules labels Sep 16, 2022
@marcusdacoregio marcusdacoregio added this to the 6.1.0-M1 milestone Dec 5, 2022
@marcusdacoregio marcusdacoregio self-assigned this Dec 5, 2022
@marcusdacoregio marcusdacoregio modified the milestones: 6.1.0-M1, 6.1.0-M2 Jan 16, 2023
@marcusdacoregio marcusdacoregio removed their assignment Mar 8, 2023
jzheaux added a commit to jzheaux/spring-security that referenced this issue Mar 17, 2023
@jzheaux jzheaux self-assigned this May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: saml2 An issue in SAML2 modules type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants