Micro performance optimizations #34717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Olivier Bourgain <[email protected]>
Signed-off-by: Olivier Bourgain <[email protected]>
The bean factory prefix is '&', so we can use a char comparison instead of more heavyweight String.startsWith("&")
Signed-off-by: Olivier Bourgain <[email protected]>
Map lookup, while cheap, is still more expensive than instanceof. Signed-off-by: Olivier Bourgain <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
type: enhancement
jhoeller
added
the
in: core
sbrannen
reviewed
Apr 4, 2025
spring-beans/src/main/java/org/springframework/beans/factory/BeanFactoryUtils.java
Show resolved
Hide resolved
sbrannen
added a commit
that referenced
this pull request
Apr 4, 2025
sbrannen
added a commit
that referenced
this pull request
Apr 4, 2025
|
Hi @obourgain, Congratulations on submitting your first PR for the Spring Framework! 👍 These optimizations have been merged in 0f2308e, polished in 381bc4c, and extended in dbd47ff. Thanks |
sbrannen
added a commit
that referenced
this pull request
Apr 22, 2025
…arameterTypes() The redundancy was reported by @TAKETODAY. See gh-34717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started testing Leyden and Spring AOT on a pretty large Spring Boot application (>1M loc). While the bootstrap was already quite efficient, I get pretty impressive results, going from 13s to about 9s.
At this point, some minor inefficiencies start to show up in profiles, so I propose low effort fixes that result in about 70-100ms improvement.