Skip to content

Add an option to disable LazyConnectionDataSourceProxy eager checkDefaultConnectionProperties call #29932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

reda-alaoui
Copy link

Fix #29931

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Feb 5, 2023
@reda-alaoui
Copy link
Author

👋

@jhoeller jhoeller removed the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 20, 2023
@jhoeller jhoeller self-assigned this Nov 20, 2023
@jhoeller jhoeller modified the milestones: 6.1.x, 6.1.2 Nov 20, 2023
@jhoeller
Copy link
Contributor

jhoeller commented Dec 7, 2023

After some back and forth, I ended up dropping the eager connection properties check completely, in favor of a late check on the first getConnection() call (but before exposing the Connection proxy, so still exposing consistent behavior for the consumer of the Connection proxy). As a consequence, there is no need for a configuration flag. If a startup-time check should be enforced (which we don't actually recommend these days), the new public checkDefaultConnectionProperties() method can be called. Even better would be to explicitly specify the defaultAutoCommit and defaultTransactionIsolation configuration settings.

I'll use the original ticket #29931 for that revision.

@jhoeller jhoeller closed this Dec 7, 2023
@jhoeller jhoeller added the status: superseded An issue that has been superseded by another label Dec 7, 2023
@jhoeller jhoeller removed this from the 6.1.2 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: data Issues in data modules (jdbc, orm, oxm, tx) status: superseded An issue that has been superseded by another type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid eager checkDefaultConnectionProperties call in LazyConnectionDataSourceProxy
4 participants