Modify status code 103 to ("Early Hints") #27960
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to rfc8297(https://tools.ietf.org/html/rfc8297), the reason phase of status code 103 should be "Early Hints", not "Checkpoint". This commit modifies the status code 103 reason phase from ("Checkpoint") to ("Early Hints").
spring-projects-issues
added
the
status: waiting-for-triage
bclozel
added
type: enhancement
bclozel
added
the
in: web
sbrannen
requested changes
Jan 20, 2022
There was a problem hiding this comment.
We unfortunately cannot accept the current proposal since it introduces breaking changes -- by changing the names of existing methods and constants.
The correct way to achieve this would be to introduce the new constants and methods and simultaneously deprecate the existing ones (pointing to the new variants).
sbrannen
added
the
status: waiting-for-feedback
|
Thank you for replying and suggesting. However i am wondering that if preserve the old constants, is that ok when use old constants value to call the method
|
spring-projects-issues
added
status: feedback-provided
simonbasle
added a commit
to simonbasle/spring-framework
that referenced
this pull request
Jan 13, 2023
This commit takes rfc8297 into account and introduces a newer code 103 HttpStatus value which uses `Early Hints` as the more correct reason phrase, deprecating the outdated `CHECKPOINT` enum value for 103. Additionally: - `HttpStatus.valueOf(103)` will return the new enum value - `HttpStatusCode#isSameCodeAs(HttpStatusCode)` is introduced to ease comparison of deprecated enums vs their newer counterparts (or any instance of a more generic `HttpStatusCode`) by comparing the integer `value()` - `HttpStatusTests` covers the new deprecation as well as the three previously deprecated codes, including a check with the above new method to ensure they have comparable integer values Supersedes and Closes spring-projectsgh-27960
simonbasle
added a commit
that referenced
this pull request
Jan 16, 2023
This commit takes rfc8297 into account and introduces a newer code 103 HttpStatus value which uses `Early Hints` as the more correct reason phrase, deprecating the outdated `CHECKPOINT` enum value for 103. Additionally: - `HttpStatus.valueOf(103)` will return the new enum value - `HttpStatusCode#isSameCodeAs(HttpStatusCode)` is introduced to ease comparison of deprecated enums vs their newer counterparts (or any instance of a more generic `HttpStatusCode`) by comparing the integer `value()` - `HttpStatusTests` covers the new deprecation as well as the three previously deprecated codes, including a check with the above new method to ensure they have comparable integer values Supersedes and Closes gh-27960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to rfc8297(https://tools.ietf.org/html/rfc8297), the reason
phase of status code 103 should be "Early Hints", not "Checkpoint".
This commit modifies the status code 103 reason phase from ("Checkpoint")
to ("Early Hints").