Compare Kind references before checking log levels #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assuming reference comparisons are much quicker than checking likely-nested logger levels, perform the former first. Also, since the reference can match only one of the instances, use "else if" to short-circuit the search.
philwebb
added a commit
that referenced
this pull request
Mar 13, 2013
# By David Harkness * patch-1: Compare Kind references before checking log levels
|
Thanks for the contribution! This has now been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming reference comparisons are much quicker than checking
the resolved logger level via the isFooEnabled() methods, reverse
the nested
if()tests. Also, since the reference can match onlyone of the instances, use
else ifto short-circuit the search.I have signed and agree to the terms of the SpringSource Individual
Contributor License Agreement.